Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: fix missing command after unnecessary install? #316

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Mar 20, 2018

(please Cargo add a real update command!)

(please Cargo add a real update command!)
@pitdicker
Copy link
Contributor

Strange problem... What do you think about the suggestion it does itself?

If you believe you received this message in error, try re-running with 'cargo -- install-update -i cargo-web'

@dhardy
Copy link
Member Author

dhardy commented Mar 20, 2018

I think Cargo was designed for interactive use and not enough thought put into automated usage. But I don't get why cargo install-update wasn't found after installing cargo-update.

@pitdicker
Copy link
Contributor

See nabijaczleweli/cargo-update#68

@pitdicker pitdicker merged commit b4cd861 into rust-random:master Mar 21, 2018
@dhardy
Copy link
Member Author

dhardy commented Mar 21, 2018

Great that this is fixed. Why then do we want this PR merged?

@pitdicker
Copy link
Contributor

An hour ago? Sorry, I didn't see harm in it 😄

@pitdicker
Copy link
Contributor

Oops, misread. I think masking errors with || true is not optimal, so this seems better to me.

@dhardy
Copy link
Member Author

dhardy commented Mar 21, 2018

🙄 the whole "install an update command just to do an update" thing is not optimal, i.e. we want to update cargo-web if necessary but not reinstall every time (with cargo install --force) because it takes ages (it was suggested we could download the binaries instead, but I view that more as a workaround). cargo install XX || true seems to be the only way to get naive Cargo to do an install only if not already installed.

@pitdicker
Copy link
Contributor

Does this make Travis time worse? Revert otherwise?

@dhardy
Copy link
Member Author

dhardy commented Mar 21, 2018

$ cargo install --force cargo-update just took 288s (nearly 5min): https://travis-ci.org/rust-lang-nursery/rand/jobs/356282613

pitdicker added a commit that referenced this pull request Apr 4, 2018
Travis: fix missing command after unnecessary install?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants